Skip to content

[Fix](TrinoConnector) it will return error when query information_schema.tables within trino-connector catalog #49912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Apr 14, 2025
Merged

[Fix](TrinoConnector) it will return error when query information_schema.tables within trino-connector catalog #49912

morningman merged 1 commit into from
Apr 14, 2025

Conversation

@BePPPower
Copy link
Contributor

@BePPPower BePPPower commented Apr 9, 2025 •
edited
Loading

Fix that it will return error when query information_schema.tables within trino-connector catalog

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

morningman
morningman approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

morningman commented Apr 9, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

TPC-H: Total hot run time: 34364 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ccfba471929f489c3d6d49f861a08a78a2314d2f, data reload: false

------ Round 1 ----------------------------------
q1	25479	5000	4961	4961
q2	2063	276	180	180
q3	10397	1226	696	696
q4	10226	1000	527	527
q5	7580	2392	2334	2334
q6	188	163	130	130
q7	901	721	624	624
q8	9317	1252	1064	1064
q9	6893	5171	5213	5171
q10	7222	2327	1885	1885
q11	515	283	301	283
q12	676	353	217	217
q13	18084	3724	3162	3162
q14	226	223	208	208
q15	530	483	481	481
q16	630	593	606	593
q17	620	851	371	371
q18	7549	7319	7198	7198
q19	2084	982	574	574
q20	352	340	240	240
q21	4035	3438	2457	2457
q22	1101	1037	1008	1008
Total cold run time: 116668 ms
Total hot run time: 34364 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5244	5423	5129	5129
q2	260	344	246	246
q3	2345	2820	2517	2517
q4	1522	2068	1641	1641
q5	4650	4871	4643	4643
q6	226	227	136	136
q7	2080	1972	1874	1874
q8	2622	2575	2499	2499
q9	7311	7312	7096	7096
q10	2971	3165	2720	2720
q11	577	517	501	501
q12	660	749	636	636
q13	3570	3892	3268	3268
q14	317	292	263	263
q15	519	462	474	462
q16	649	687	650	650
q17	1146	1591	1404	1404
q18	7824	7674	7557	7557
q19	830	791	846	791
q20	1928	1966	1830	1830
q21	5362	4832	4831	4831
q22	1132	1085	1005	1005
Total cold run time: 53745 ms
Total hot run time: 51699 ms

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

TPC-DS: Total hot run time: 192644 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ccfba471929f489c3d6d49f861a08a78a2314d2f, data reload: false

query1	1389	1070	1026	1026
query2	6324	1932	1934	1932
query3	11172	4608	4606	4606
query4	25293	23824	22789	22789
query5	5342	602	451	451
query6	299	211	193	193
query7	3983	488	273	273
query8	316	226	227	226
query9	8500	2560	2555	2555
query10	465	305	272	272
query11	15593	15014	14985	14985
query12	164	111	104	104
query13	1565	516	396	396
query14	9493	6055	6054	6054
query15	197	188	167	167
query16	7599	631	423	423
query17	1163	757	616	616
query18	2040	427	320	320
query19	198	197	178	178
query20	133	127	130	127
query21	207	133	109	109
query22	4508	4507	4546	4507
query23	34213	33281	33405	33281
query24	8283	2440	2403	2403
query25	548	471	414	414
query26	1191	274	146	146
query27	2813	498	336	336
query28	4856	2428	2420	2420
query29	694	601	441	441
query30	272	228	194	194
query31	903	870	792	792
query32	74	63	64	63
query33	530	361	311	311
query34	790	865	514	514
query35	842	868	796	796
query36	1010	1035	892	892
query37	118	100	73	73
query38	4341	4290	4078	4078
query39	1504	1429	1445	1429
query40	208	120	113	113
query41	54	52	52	52
query42	117	108	112	108
query43	499	531	491	491
query44	1308	816	795	795
query45	180	179	185	179
query46	852	1040	653	653
query47	1845	1881	1831	1831
query48	382	417	320	320
query49	762	531	414	414
query50	654	683	393	393
query51	4286	4275	4218	4218
query52	111	103	98	98
query53	232	259	185	185
query54	611	572	509	509
query55	79	80	85	80
query56	332	295	278	278
query57	1166	1217	1138	1138
query58	269	261	262	261
query59	2728	2869	2811	2811
query60	333	319	303	303
query61	133	133	137	133
query62	758	770	669	669
query63	223	187	183	183
query64	4064	1063	709	709
query65	4396	4420	4405	4405
query66	913	404	309	309
query67	16579	15484	15337	15337
query68	8868	889	510	510
query69	501	307	256	256
query70	1191	1106	1103	1103
query71	466	307	293	293
query72	5686	4857	4887	4857
query73	738	647	345	345
query74	8934	9272	8929	8929
query75	4036	3190	2700	2700
query76	3716	1177	753	753
query77	778	378	266	266
query78	10056	10233	9267	9267
query79	1646	816	559	559
query80	622	506	467	467
query81	467	261	221	221
query82	446	124	95	95
query83	275	253	240	240
query84	298	117	90	90
query85	756	352	402	352
query86	334	309	271	271
query87	4503	4476	4260	4260
query88	2756	2203	2252	2203
query89	405	323	273	273
query90	1951	207	208	207
query91	138	142	113	113
query92	75	61	54	54
query93	1098	970	594	594
query94	668	400	315	315
query95	370	293	283	283
query96	481	560	267	267
query97	3209	3222	3131	3131
query98	213	206	198	198
query99	1406	1423	1305	1305
Total cold run time: 280086 ms
Total hot run time: 192644 ms

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

ClickBench: Total hot run time: 31.75 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ccfba471929f489c3d6d49f861a08a78a2314d2f, data reload: false

query1	0.04	0.04	0.02
query2	0.12	0.11	0.11
query3	0.24	0.20	0.19
query4	1.59	0.19	0.20
query5	0.59	0.58	0.59
query6	1.20	0.72	0.70
query7	0.03	0.02	0.01
query8	0.04	0.03	0.03
query9	0.60	0.53	0.53
query10	0.58	0.58	0.57
query11	0.16	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.62
query14	2.65	2.79	2.82
query15	0.94	0.87	0.85
query16	0.38	0.39	0.39
query17	1.03	1.00	1.06
query18	0.21	0.20	0.21
query19	1.89	1.92	1.89
query20	0.02	0.01	0.01
query21	15.35	0.90	0.54
query22	0.76	1.21	0.79
query23	14.77	1.40	0.62
query24	7.21	1.16	1.19
query25	0.49	0.26	0.11
query26	0.57	0.16	0.16
query27	0.05	0.05	0.05
query28	9.24	0.86	0.42
query29	12.55	3.99	3.29
query30	0.25	0.08	0.06
query31	2.82	0.58	0.38
query32	3.22	0.55	0.47
query33	2.99	3.04	3.07
query34	15.79	5.13	4.50
query35	4.52	4.53	4.48
query36	0.67	0.50	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.18	0.14	0.13
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.05
Total cold run time: 104.79 s
Total hot run time: 31.75 s

@morningman morningman force-pushed the fixTrinoConnectorInformationSchema branch from ccfba47 to a36d9b2 Compare April 10, 2025 04:34
@morningman
Copy link
Contributor

morningman commented Apr 10, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 10, 2025

TPC-H: Total hot run time: 34197 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a36d9b28746e741f80c2c2c80a2136645f050e18, data reload: false

------ Round 1 ----------------------------------
q1	25883	5067	5006	5006
q2	2070	302	188	188
q3	10399	1263	706	706
q4	10251	1023	546	546
q5	8384	2452	2390	2390
q6	186	161	132	132
q7	920	737	598	598
q8	9300	1288	1058	1058
q9	6881	5102	5087	5087
q10	6822	2276	1870	1870
q11	482	279	270	270
q12	344	363	220	220
q13	17785	3666	3063	3063
q14	225	224	219	219
q15	538	480	501	480
q16	623	627	600	600
q17	613	860	387	387
q18	7544	7554	7108	7108
q19	1750	962	550	550
q20	340	345	231	231
q21	4502	3499	2517	2517
q22	1054	999	971	971
Total cold run time: 116896 ms
Total hot run time: 34197 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5176	5090	5098	5090
q2	249	334	239	239
q3	2181	2661	2296	2296
q4	1422	1931	1494	1494
q5	4567	4454	4290	4290
q6	212	168	127	127
q7	1965	1893	1749	1749
q8	2573	2615	2528	2528
q9	7132	7149	7239	7149
q10	3016	3149	2767	2767
q11	568	517	495	495
q12	685	720	636	636
q13	3587	3842	3243	3243
q14	292	290	288	288
q15	517	482	478	478
q16	625	682	648	648
q17	1134	1536	1379	1379
q18	7682	7392	7398	7392
q19	806	831	791	791
q20	1984	1963	1831	1831
q21	5225	4649	4662	4649
q22	1080	1022	986	986
Total cold run time: 52678 ms
Total hot run time: 50545 ms

@doris-robot
Copy link

doris-robot commented Apr 10, 2025

TPC-DS: Total hot run time: 185856 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a36d9b28746e741f80c2c2c80a2136645f050e18, data reload: false

query1	1001	473	471	471
query2	6543	1928	1912	1912
query3	6749	218	214	214
query4	26175	23067	23568	23067
query5	4816	636	477	477
query6	322	201	194	194
query7	4630	490	278	278
query8	304	243	247	243
query9	8644	2580	2584	2580
query10	501	326	269	269
query11	15418	15274	14763	14763
query12	162	112	116	112
query13	1672	509	410	410
query14	8872	6047	6299	6047
query15	204	188	169	169
query16	7343	653	461	461
query17	1176	717	583	583
query18	1986	421	304	304
query19	191	193	170	170
query20	121	119	118	118
query21	212	123	112	112
query22	4404	4146	4251	4146
query23	33898	33007	33122	33007
query24	7701	2346	2412	2346
query25	535	454	391	391
query26	1233	262	146	146
query27	2691	479	337	337
query28	4436	2398	2409	2398
query29	774	566	432	432
query30	285	215	191	191
query31	922	830	765	765
query32	70	64	62	62
query33	568	366	306	306
query34	800	838	518	518
query35	767	817	738	738
query36	955	991	905	905
query37	112	98	76	76
query38	4071	4061	4228	4061
query39	1506	1413	1400	1400
query40	208	121	109	109
query41	55	53	51	51
query42	120	106	104	104
query43	500	506	468	468
query44	1325	804	804	804
query45	175	174	165	165
query46	819	1007	627	627
query47	1742	1796	1752	1752
query48	362	416	291	291
query49	789	532	409	409
query50	642	687	412	412
query51	4110	4157	4157	4157
query52	112	106	100	100
query53	224	261	178	178
query54	568	564	498	498
query55	81	78	89	78
query56	317	302	291	291
query57	1100	1171	1090	1090
query58	289	255	291	255
query59	2795	2746	2691	2691
query60	321	308	307	307
query61	164	126	123	123
query62	809	718	655	655
query63	228	185	179	179
query64	4353	1005	683	683
query65	4382	4288	4252	4252
query66	1150	436	306	306
query67	15903	15702	15567	15567
query68	8614	882	510	510
query69	479	299	257	257
query70	1252	1113	1056	1056
query71	493	316	290	290
query72	5758	4727	4586	4586
query73	743	625	342	342
query74	8873	9052	8709	8709
query75	3909	3185	2710	2710
query76	3738	1190	760	760
query77	805	369	274	274
query78	10112	10149	9308	9308
query79	3436	819	565	565
query80	649	496	413	413
query81	467	254	218	218
query82	668	128	98	98
query83	289	266	238	238
query84	294	174	83	83
query85	787	364	313	313
query86	336	305	292	292
query87	4389	4394	4269	4269
query88	3193	2178	2194	2178
query89	424	310	279	279
query90	1928	213	208	208
query91	141	140	113	113
query92	78	63	58	58
query93	2180	945	574	574
query94	674	409	283	283
query95	374	292	281	281
query96	493	558	268	268
query97	3281	3215	3082	3082
query98	239	211	204	204
query99	1466	1412	1256	1256
Total cold run time: 276975 ms
Total hot run time: 185856 ms

@doris-robot
Copy link

doris-robot commented Apr 10, 2025

ClickBench: Total hot run time: 31.3 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a36d9b28746e741f80c2c2c80a2136645f050e18, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.10
query3	0.24	0.19	0.20
query4	1.59	0.20	0.20
query5	0.57	0.54	0.56
query6	1.17	0.72	0.71
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.57	0.52	0.52
query10	0.62	0.58	0.56
query11	0.15	0.10	0.10
query12	0.14	0.11	0.12
query13	0.62	0.59	0.60
query14	2.73	2.74	2.70
query15	0.93	0.85	0.85
query16	0.37	0.37	0.38
query17	1.01	1.03	1.03
query18	0.20	0.19	0.19
query19	2.06	1.86	1.80
query20	0.01	0.01	0.02
query21	15.35	0.89	0.54
query22	0.75	1.18	0.93
query23	14.72	1.44	0.66
query24	6.64	1.37	0.74
query25	0.46	0.15	0.07
query26	0.72	0.16	0.14
query27	0.05	0.06	0.05
query28	9.04	0.88	0.42
query29	12.53	3.99	3.36
query30	0.25	0.09	0.06
query31	2.88	0.60	0.39
query32	3.22	0.54	0.46
query33	3.03	3.12	3.07
query34	15.80	5.10	4.45
query35	4.52	4.54	4.51
query36	0.67	0.49	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.03	0.04	0.03
Total cold run time: 104.31 s
Total hot run time: 31.3 s

@morningman morningman merged commit 7710b17 into apache:master Apr 14, 2025
29 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 14, 2025
@BePPPower
[Fix](TrinoConnector) it will return error when query `information_sc…
1659cec 
…hema.tables` within `trino-connector` catalog (#49912)

Fix that it will return error when query `information_schema.tables`
within `trino-connector` catalog
@github-actions github-actions bot mentioned this pull request Apr 14, 2025
Merged
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 17, 2025
@BePPPower @seawinde
[Fix](TrinoConnector) it will return error when query `information_sc…
7a83637 
…hema.tables` within `trino-connector` catalog (apache#49912)

Fix that it will return error when query `information_schema.tables`
within `trino-connector` catalog
dataroaring pushed a commit that referenced this pull request Apr 23, 2025
@github-actions @BePPPower
branch-3.0: [Fix](TrinoConnector) it will return error when query `in…
b2b0dae 
…formation_schema.tables` within `trino-connector` catalog #49912 (#50006)

Cherry-picked from #49912

Co-authored-by: Tiewei Fang <fangtiewei@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@BePPPower @koarz
[Fix](TrinoConnector) it will return error when query `information_sc…
86e0ff7 
…hema.tables` within `trino-connector` catalog (apache#49912)

Fix that it will return error when query `information_schema.tables`
within `trino-connector` catalog
@gavinchou gavinchou mentioned this pull request Jun 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@zy-kkk zy-kkk zy-kkk approved these changes

+2 more reviewers

@suxiaogang223 suxiaogang223 suxiaogang223 approved these changes

@hubgeter hubgeter hubgeter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.6-merged p0_test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@BePPPower @Thearas @morningman @doris-robot @CalvinKirs @suxiaogang223 @zy-kkk @hubgeter @dataroaring